Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link projects in program areas page to project page #3592

Closed
7 tasks done
jdingeman opened this issue Sep 30, 2022 · 6 comments · Fixed by #3692
Closed
7 tasks done

Link projects in program areas page to project page #3592

jdingeman opened this issue Sep 30, 2022 · 6 comments · Fixed by #3692
Assignees
Labels
Complexity: Medium P-Feature: Program Area https://www.hackforla.org/program-areas P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review
Milestone

Comments

@jdingeman
Copy link
Member

jdingeman commented Sep 30, 2022

Overview

We need to ensure that the Hack for LA project page links are attached to their respective project cards on program areas page.

Details

Developers have noted that the files in /_projects do not have the links for their respective project pages. Previously, when a user clicked on the title of a program card, they would be led to the Hack for LA project specific webpage, but currently they lead to the GitHub project webpage. We need make it so when a user clicks on the link in the mini-cards, they are redirected to the project page.

Action Items / Pseudo Code

  • Research Liquid if it is possible to reference the project filename
  • Go to pages/program-areas.html and navigate to the <ul class="project-card-mini-list-alignment"> element
  • Within the for loop, assign the filename to a variable as a string
    • Manipulate the string in the variable to exlcude the .md portion of the filename
    • Append this to projects page link so that it will lead directly to whichever project page it is referencing
  • Change the href in <a class="project-card-mini-title" href="{{project.links[0].url}}">{{project.title}}</a> so that it links the title of the project card to the project page

Resources

@jdingeman jdingeman added Size: Good second issue epic Draft Issue is still in the process of being created labels Sep 30, 2022
@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing labels Sep 30, 2022
@jdingeman jdingeman added role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) and removed role missing Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Sep 30, 2022
@jdingeman jdingeman added Dependency An issue is blocking the completion or starting of another issue Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed Size: Good second issue labels Oct 14, 2022
@jdingeman jdingeman added Complexity: Medium Ready for Prioritization and removed Dependency An issue is blocking the completion or starting of another issue Complexity: Small Take this type of issues after the successful merge of your second good first issue epic labels Oct 25, 2022
@jdingeman jdingeman changed the title Add project links to _projects files Link projects in program areas page to project page Oct 25, 2022
@jdingeman jdingeman added the role: front end Tasks for front end developers label Oct 25, 2022
@ExperimentsInHonesty ExperimentsInHonesty removed the Draft Issue is still in the process of being created label Oct 31, 2022
@ExperimentsInHonesty ExperimentsInHonesty added this to the 05. Know HFLA milestone Oct 31, 2022
@ExperimentsInHonesty ExperimentsInHonesty added P-Feature: Program Area https://www.hackforla.org/program-areas and removed Ready for Prioritization labels Oct 31, 2022
@luiderek luiderek self-assigned this Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Hi @luiderek, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@luiderek
Copy link
Member

luiderek commented Nov 3, 2022

Availability: 10am-10pm PDT
ETA: < 4 hours

@ExperimentsInHonesty
Copy link
Member

While reviewing this page, I see that the project mini card doesn't work for long titles
https://www.hackforla.org/program-areas.html
image

@ExperimentsInHonesty
Copy link
Member

Product to make a new issue to deal with the long titles.
We have to look at why the titles are long, can they be shortended and is there a limit

@ExperimentsInHonesty
Copy link
Member

@hackforla/website-merge

I have looked at the project names and only two are a problem.
image
image

I suggest the following name changes
change

Los Angeles Criminal Sentencing Project

to

LA Criminal Sentencing

Change

Not Today - Self-Defense Against Suicidal Thoughts

to

Not Today

and change the description for the project from

Not Today is an app intended to help people wait out periods of suicidal thinking without acting on their thoughts.

to

Not Today - the self-defense against suicidal thoughts app is intended to help people wait out periods of suicidal thinking without acting on their thoughts.

Please make an issue

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed ready for product labels Feb 26, 2023
@jdingeman
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Program Area https://www.hackforla.org/program-areas P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

3 participants