Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Problem, Solution, and Impact Sections to Project Pages #3547

Closed
7 of 8 tasks
kathrynsilvaconway opened this issue Sep 13, 2022 · 15 comments · Fixed by #3767
Closed
7 of 8 tasks

Add Problem, Solution, and Impact Sections to Project Pages #3547

kathrynsilvaconway opened this issue Sep 13, 2022 · 15 comments · Fixed by #3767
Assignees
Labels
Complexity: Medium P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 3pt Can be done in 13-18 hours Status: Updated No blockers and update is ready for review
Milestone

Comments

@kathrynsilvaconway
Copy link
Member

kathrynsilvaconway commented Sep 13, 2022

Overview

We need to design an additional section in the project page code that displays the Problem, Solution, and Impact & SDG info on each individual project page so that development can build the content into the site.

Details

Click here to see screenshot of proposed Figma design

image

View the type of page that new content layout will go on https://www.hackforla.org/projects/100-automations

Action Items

Note that you will only be updating one HTML file: _layouts/project.html). All project pages are generated from this file. There is not a separate file for every project

  • Examine the existing project page
  • Examine the Figma page for this issue and implement the code changes
  • In between the Project Description Card and Project Resources Card sections in _layouts/project.html apply the following logic:
    • Create a new div for Project Value Card
    • Use Liquid to make an if-statement that will render the Project Value Card if the project file being called in /_projects has data listed under problem
      • i.e. If project.problem exists, render the Project Value Card with all the information in project.problem, project.solution and project.impact
      • Otherwise, do not render the Project Value Card
  • Submit a pull request.

Resources/Instructions

Project page

@kathrynsilvaconway kathrynsilvaconway added role: front end Tasks for front end developers Complexity: Medium P-Feature: Projects page https://www.hackforla.org/projects/ ready for dev lead Issues that tech leads or merge team members need to follow up on size: 3pt Can be done in 13-18 hours Draft Issue is still in the process of being created labels Sep 13, 2022
@kathrynsilvaconway

This comment was marked as resolved.

@JessicaLucindaCheng

This comment was marked as resolved.

@kathrynsilvaconway kathrynsilvaconway added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on Draft Issue is still in the process of being created labels Oct 4, 2022
@bishrfaisal

This comment was marked as resolved.

@bishrfaisal bishrfaisal added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Ready for Prioritization labels Oct 17, 2022
@blulady

This comment was marked as resolved.

@blulady blulady added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Oct 25, 2022
@JessicaLucindaCheng

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Ready for Prioritization labels Oct 25, 2022
@blulady

This comment was marked as resolved.

@blulady blulady added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Oct 28, 2022
@7kram

This comment was marked as resolved.

@7kram 7kram added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Ready for Prioritization labels Nov 2, 2022
@ExperimentsInHonesty

This comment was marked as outdated.

@jdingeman jdingeman added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Nov 11, 2022
@JessicaLucindaCheng

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Ready for Prioritization labels Nov 13, 2022
@jdingeman jdingeman added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Nov 14, 2022
@JessicaLucindaCheng

This comment was marked as outdated.

@7kram 7kram added this to the 05. Know HFLA milestone Nov 20, 2022
@patrickohh patrickohh self-assigned this Nov 28, 2022
@github-actions
Copy link

Hi @patrickohh, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@patrickohh
Copy link
Member

patrickohh commented Nov 28, 2022

i. Availability: 11/29 - 12/3
ii. ETA: 12/1 Evening

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Dec 2, 2022
@patrickohh
Copy link
Member

  1. Progress: Got the problem, solution, and impact fields to render in a value card on the page.
  2. Blockers: Trying to use the css components already available in the page's scss file, but finding that they do not render the value card with dimensions represented in the figma diagram. Looking to making my own css components for this card, but will ask if this is something that still pertains to the scope of this issue.
  3. Availability: 12/5 - 12/6
  4. ETA: 12/5 Evening PST

@ExperimentsInHonesty
Copy link
Member

We need an issue to create a DR about leaving the format for this Impact card in the _sass/components/_project-page.scss file instead of moving it to a parent class. If later we need to use the format again, it should be extracted and moved to a higher level.

@ExperimentsInHonesty ExperimentsInHonesty added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Feb 14, 2023
@jdingeman
Copy link
Member

jdingeman commented Mar 3, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 3pt Can be done in 13-18 hours Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

8 participants