Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform site audit of mobile navigation #2190

Closed
5 tasks done
kristine-eudey opened this issue Aug 27, 2021 · 21 comments
Closed
5 tasks done

Perform site audit of mobile navigation #2190

kristine-eudey opened this issue Aug 27, 2021 · 21 comments
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system p-Feature: Mobile ready for design lead role: design size: 0.5pt Can be done in 3 hours or less

Comments

@kristine-eudey
Copy link
Member

kristine-eudey commented Aug 27, 2021

Dependency

We need to determine how we will add this audit of navigation elements to the design system. An issue will be created to improve the design system and determine if we need a navigation component menu added to it.

Overview

We need to audit all the current mobile navigation on the site and create documentation for them in the design system so that the design team is able to pull from these options and design future mobile pages with greater ease and consistency.

Action Items

  • Create new page in Figma titled "Mobile Menus Audit"
  • Go through all mobile pages in Figma, copying all instances of menus and navigation patterns used across the site.
  • Copy each instance to the "Mobile Menus Audit" page, noting which page on the site it came from
  • Analyze findings: did you notice any inconsistencies or issues? Do you see any room for improvement, or recommend any changes based on what you found?
  • Present to the larger team to share the findings.

Resources/Instructions

Hack for LA - Figma Mobile audit
Basic patterns for mobile navigation: Pros and Cons (Smashing Magazine)

@kristine-eudey kristine-eudey added role: design Feature: Design system Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Aug 27, 2021
@github-actions

This comment has been minimized.

@kristine-eudey

This comment has been minimized.

@github-actions github-actions bot added the To Update ! No update has been provided label Sep 10, 2021
@github-actions

This comment has been minimized.

@kristine-eudey

This comment has been minimized.

@github-actions github-actions bot removed the To Update ! No update has been provided label Sep 17, 2021
@github-actions

This comment has been minimized.

@github-actions github-actions bot added the To Update ! No update has been provided label Sep 17, 2021
@github-actions

This comment has been minimized.

@github-actions github-actions bot added To Update ! No update has been provided and removed To Update ! No update has been provided labels Sep 24, 2021
@ashleylin1
Copy link
Member

Progress: Finished adding navigation component menu
Blockers: None
Availability: Weekends
ETA: Finished
Pictures:
image
image

@github-actions github-actions bot added Status: Updated No blockers and update is ready for review and removed To Update ! No update has been provided labels Oct 1, 2021
@kristine-eudey
Copy link
Member Author

Thank you @ashleylin1! Issue complete. Mobile navigation audit can be found here: Figma - Mobile Navigation Audit

@github-actions

This comment has been minimized.

@IsaacDesigns

This comment has been minimized.

@IsaacDesigns IsaacDesigns removed the time sensitive Needs to be worked on by a particular timeframe label Jan 5, 2022
@ExperimentsInHonesty ExperimentsInHonesty added the Dependency An issue is blocking the completion or starting of another issue label Jan 5, 2022
@IsaacDesigns
Copy link
Member

IsaacDesigns commented Jan 6, 2022

Progress: I have determined the next steps in this issue is to identify if there's anything in this audit that isn't represented in the Design System. Anything found that isn't represented in the Design System should then be assessed to determine if it should either be added to the DS.
Blockers: None
Availability: 3 hours
ETA: 5 days

@IsaacDesigns IsaacDesigns added size: 0.5pt Can be done in 3 hours or less and removed Dependency An issue is blocking the completion or starting of another issue labels Jan 6, 2022
@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Jan 7, 2022
@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Jan 12, 2022

The navigation elements should be added to the design system if they are not there and if they are there, then the mobile views needed to be added as a context example. In order to accommodate that, add two more columns
Desktop context example, Tablet, Mobile

@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label Jan 14, 2022
@github-actions
Copy link

@IsaacDesigns

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, January 10, 2022 at 11:19 PM PST.

@IsaacDesigns
Copy link
Member

Progress: Bonnie and I have determined that the navigation elements should be added to the design system if they are not there and if they are there, then the mobile views needed to be added as a context example. In order to accommodate that I will add two more columns for Desktop, Tablet, and Mobile context example.
Blockers: None
Availability: 4 hours
ETA: 1/21/2022

@github-actions github-actions bot added Status: Updated No blockers and update is ready for review 2 weeks inactive and removed Status: Updated No blockers and update is ready for review labels Jan 21, 2022
@hackforla hackforla deleted a comment from github-actions bot Feb 4, 2022
@hackforla hackforla deleted a comment from github-actions bot Feb 4, 2022
@IsaacDesigns
Copy link
Member

Finished adding components to Design System. We will need to create an issue to add two more columns for Desktop, and Tablet context examples.

@ExperimentsInHonesty
Copy link
Member

I am moving this back to new issue approval column to indicate that the new design lead, or product team will have to make an issue for the changes needed to expand the design system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system p-Feature: Mobile ready for design lead role: design size: 0.5pt Can be done in 3 hours or less
Projects
Status: New Issue Approval
Development

No branches or pull requests

5 participants