Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client-side validation for LinkedIn contact detail field #2199

Closed
3 tasks
Tracked by #2128
SAUMILDHANKAR opened this issue Aug 27, 2024 · 1 comment
Closed
3 tasks
Tracked by #2128

Add client-side validation for LinkedIn contact detail field #2199

SAUMILDHANKAR opened this issue Aug 27, 2024 · 1 comment
Labels
dev Code Development good first issue Good for newcomers P-Feature: Admin Dashboard Admin dashboard page Priority - Med Needs to be in the next release Release Note: Enhancement Shows on Release Notes under "Enhancements" Role: Front-end Front End Developer size: 1pt The lift to complete this user story 1-2hrs

Comments

@SAUMILDHANKAR
Copy link
Member

SAUMILDHANKAR commented Aug 27, 2024

Overview

We would like the data entered in our contact fields to be accurate. In this issue, we will add client-side validation for the LinkedIn contact field.

Action Items

  • URL would have 2 parts: first would be fixed (https://www.linkedin.com/) and the second would be the one entered by the person creating the contact field for example LinkedIn company company/food-oasis-la/ or individual or a group that should satisfy the LinkedIn policies. Some of the policies are listed in issue Add tooltip for LinkedIn contact detail field #2197. Please see the Pinterest contact field image below for reference:
    For issue 2180
  • Add a clickable link for the user so they can click it and test that the link works.
  • Test it in your dev environment.

Resources/Instructions

@SAUMILDHANKAR SAUMILDHANKAR added good first issue Good for newcomers dev Code Development Role: Front-end Front End Developer size: 1pt The lift to complete this user story 1-2hrs P-Feature: Admin Dashboard Admin dashboard page labels Aug 27, 2024
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: FOLA: Project Board Aug 27, 2024
@SAUMILDHANKAR SAUMILDHANKAR moved this from New Issue Approval to Prioritized Backlog in P: FOLA: Project Board Aug 27, 2024
@entrotech entrotech added Release Note: Enhancement Shows on Release Notes under "Enhancements" Priority - Med Needs to be in the next release labels Sep 24, 2024
@sumit-sharma92 sumit-sharma92 added the Missing: Milestone This issue is not part of any milestone label Sep 26, 2024
@ExperimentsInHonesty ExperimentsInHonesty removed the Missing: Milestone This issue is not part of any milestone label Nov 7, 2024
@SAUMILDHANKAR
Copy link
Member Author

after merging #2279, all the social media contact details have consistent validation methodology as of today. Reached out to Hannah and we are planning to go for an upgrade in validation such that if user enters some field with error we would take them to the field which has the error but that would be worked in a separate issue. So, I am closing this issue.

@github-project-automation github-project-automation bot moved this from Prioritized Backlog to Done in P: FOLA: Project Board Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Code Development good first issue Good for newcomers P-Feature: Admin Dashboard Admin dashboard page Priority - Med Needs to be in the next release Release Note: Enhancement Shows on Release Notes under "Enhancements" Role: Front-end Front End Developer size: 1pt The lift to complete this user story 1-2hrs
Projects
Development

No branches or pull requests

4 participants