Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Audit Colors] in Landing page #825

Closed
14 tasks done
Tracked by #823
anitadesigns opened this issue Feb 16, 2023 · 6 comments
Closed
14 tasks done
Tracked by #823

[ Audit Colors] in Landing page #825

anitadesigns opened this issue Feb 16, 2023 · 6 comments
Assignees
Labels
feature: design system issues relating to the general design system feature: figma wireframes priority: high role: design anything related to design size: 1pt can be done in 6 hours or less

Comments

@anitadesigns
Copy link
Member

anitadesigns commented Feb 16, 2023

Overview

Extension of #823 . Audit mobile and desktop wireframes under "Design System Audit" on Figma. This issue is split into two parts: Auditing Mobile/Desktop wireframes and Auditing screenshot of page on expungeassist.org

Action Items

Auditing Mobile/Desktop wireframes

  • Select each individual "atom" on a wireframe
  • Assess what Hex code and color style is being used
  • Add metadata (color swap, location, style being used, Hex code, opacity )
    Example:
    Screen Shot 2023-04-26 at 9 01 03 PM
  • Use AutoFlow plugin to draw an arrow to each "atom" and element's color metadata
    • If "atom" is not using a color style, use the Orange (color style saved in Figma library) arrow and note the HEX code being used
    • If an old color style is being used, change the text sharing location and color style to red (use color style saved in Figma library)
  • Note any inconsistencies to share with the team

Auditing screenshot of page on expungeassist.org

  • Use Google Chrome's "inspect" tool to view website's code
  • Assess what Hex code and .jss component is being used
  • Add metadata on screenshot in Figma (color swap, location, hex code, .jss rule)
  • Draw an arrow from element to metadata on Figma

Next steps

  • Comment in this issue "Completed. Ready for Review" and tag "@anitadesigns". Add any other information that is important to share in the comments
  • Unassign yourself and assign "@anitadesigns " to issue
  • Move issue from "In Progress" to "Ready for Review" on the project board

Resources/Instructions

Reach out to @anitadesigns if you have any questions.

@anitadesigns anitadesigns added role: design anything related to design priority: high size: 1pt can be done in 6 hours or less feature: design system issues relating to the general design system feature: figma wireframes labels Feb 16, 2023
@anitadesigns
Copy link
Member Author

anitadesigns commented Apr 27, 2023

Hexcodes were pulled, but missing the rest of the metadata. Need to re-do to keep a consistent format

@mbui31
Copy link
Member

mbui31 commented May 25, 2023

@anitadesigns I commented in the Figma file that the live website couldn't be audited because it's not the version with components + vectors, but it's an image of the website. If there's a version with the design assets, lmk and I can continue with auditing. Otherwise, the mobile and desktop wireframes are done being audited. Handing them back to you for review!

@mbui31
Copy link
Member

mbui31 commented May 25, 2023

@anitadesigns Also, I pulled up the EA's Landing page website and it is not what I see on Figma. There's a big discrepancy and so I cannot use the "inspect" tool since the 2 versions are different.

@mbui31 mbui31 assigned anitadesigns and unassigned mbui31 May 25, 2023
@anitadesigns
Copy link
Member Author

Noticed the wrong screen shot was added to this section and replaced it with the correct one. I check the annotations for the desktop and mobile frames and it looks great! Assigning it back to @mbui31 to finish the live website section

@anitadesigns anitadesigns assigned mbui31 and unassigned anitadesigns May 26, 2023
@mbui31
Copy link
Member

mbui31 commented Jun 19, 2023

@anitadesigns thank you for updating the live website; finished the audit and reassigning to ya

@mbui31
Copy link
Member

mbui31 commented Jun 19, 2023

"Completed. Ready for Review"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: design system issues relating to the general design system feature: figma wireframes priority: high role: design anything related to design size: 1pt can be done in 6 hours or less
Projects
Development

No branches or pull requests

4 participants