Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research Migration Details #1576

Closed
9 tasks done
Tracked by #1575 ...
sydneywalcoff opened this issue Sep 27, 2024 · 9 comments
Closed
9 tasks done
Tracked by #1575 ...

Research Migration Details #1576

sydneywalcoff opened this issue Sep 27, 2024 · 9 comments
Assignees
Labels
feature: technical standards accessibility, usability, unit testing, etc. front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person priority: high role: development anything related to code size: 2pt Can be done in 7-12 hours Status: Update Requested

Comments

@sydneywalcoff
Copy link
Member

sydneywalcoff commented Sep 27, 2024

Overview

The Create React App(CRA) deprecation leaves EA open to lack of support, security risks, and performance issues. To avoid issues moving forward, EA is migrating to use Vite as our build tool.

Action Items

  • read getting started/migration docs
  • answer questions
    • do we have CRA specific code that needs to be updated?
    • does this effect testing? if so, how?
  • handoff to Dev Conduct Migration #1577
    • add research question results
    • remove dependency The issue or reason why this issue is in the icebox label
    • add ready for dev lead task ready for dev lead to evaluate label
    • move to new issue approval column

Resources/Notes

Vite Docs

Notes & Questions

  • Is our type checking and/or linting coming from CRA?

    • linting: no
    • type checking: typescript
  • Process?

    • in the /products folder, run npm create vite@latest
    • use the react-ts template
    • call the new folder statement-generator-vite
    • move to the /statement-generator-vite folder and run npm i then runnpm run dev
    • make sure it compiles without any problems
    • install packages AT the version listed in /statement-generator/package.json
      • everything except packages related to @testing-library and react-scripts
    • update /statement-generator-vite/package.json scripts
    • copy over content of /statement-generator/src and /statement-generator/public folders
      • a lot will just be able to be copy-pasted over
      • /statement-generator/public
        • copy everything except:
          • logo192.png
          • logo512.png
        • comment out the manifest.json
      • /statement-generator/src
        • only files not copied over:
          • setupTests.js
          • react-app-env.d.ts
    • rename ENV variables
    • resolve any warnings that may come up
    • translate /statement-generator/tsconfig.json settings into /statement-generator-vite/tsconfig.json
      • if anything is conflicting notate what the default generated setting in /statement-generator-vite/tsconfig.json is and replace it with the value in the CRA set up.
    • update /.github/workflows/master-deploy.yml
      • change folder: products/statement-generator/build to folder: products/statement-generator/dist
    • test locally
      • running the build command and making sure it builds successfully
      • running the preview command and making sure the app looks and runs correctly
  • Testing

    • this will affect any test suites that utilize @testing-library which is most of them. I'm setting up a separate issue to migrate our testing stuff once that's complete
This was referenced Sep 27, 2024
@sydneywalcoff sydneywalcoff added role: development anything related to code priority: high draft Not yet ready to be worked on size: 1pt can be done in 6 hours or less feature: technical standards accessibility, usability, unit testing, etc. front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person labels Sep 27, 2024
@github-project-automation github-project-automation bot moved this to New Issues for approval in P: EA: Project Board Sep 27, 2024
@sydneywalcoff sydneywalcoff added this to the Stakeholder Review 2.0 milestone Sep 27, 2024
@sydneywalcoff sydneywalcoff moved this from New Issues for approval to In Progress (active) in P: EA: Project Board Nov 8, 2024
@sydneywalcoff sydneywalcoff removed the draft Not yet ready to be worked on label Nov 8, 2024
@sydneywalcoff sydneywalcoff self-assigned this Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Hey @sydneywalcoff! Thanks for taking this issue.

To help keep everyone in the loop, please comment your Estimated Time to Completion (ETC) below!

Thanks again!

@sydneywalcoff
Copy link
Member Author

ETC: 3 days

@sydneywalcoff
Copy link
Member Author

Progress: I completed the migration from a research perspective on a personal project. I'm now notating the application for EA.
Estimated Time to Completion (ETC): Another couple days (3?)
Blockers: Nope

@sydneywalcoff sydneywalcoff added size: 2pt Can be done in 7-12 hours and removed size: 1pt can be done in 6 hours or less labels Nov 13, 2024
Copy link

Hey @sydneywalcoff! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

Copy link

github-actions bot commented Dec 1, 2024

Hey @sydneywalcoff! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

4 similar comments
Copy link

Hey @sydneywalcoff! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

Copy link

Hey @sydneywalcoff! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

Copy link

Hey @sydneywalcoff! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

Copy link

github-actions bot commented Jan 5, 2025

Hey @sydneywalcoff! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@github-project-automation github-project-automation bot moved this from In Progress (active) to Done in P: EA: Project Board Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: technical standards accessibility, usability, unit testing, etc. front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person priority: high role: development anything related to code size: 2pt Can be done in 7-12 hours Status: Update Requested
Projects
Development

No branches or pull requests

2 participants