Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG Progress Bar Testing #1246

Closed
4 tasks done
Tracked by #1241 ...
sydneywalcoff opened this issue Mar 11, 2024 · 6 comments · Fixed by #1662
Closed
4 tasks done
Tracked by #1241 ...

LG Progress Bar Testing #1246

sydneywalcoff opened this issue Mar 11, 2024 · 6 comments · Fixed by #1662
Assignees
Labels
DevOps type of development task related to Process, Github Actions, and Deployment feature: technical standards accessibility, usability, unit testing, etc. front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person priority: low role: development anything related to code size: 3pt Can be done in 13-18 hours Status: Update Requested

Comments

@sydneywalcoff
Copy link
Member

sydneywalcoff commented Mar 11, 2024

Dependency

Overview

Testing is an important part of the development process that has been ignored in the Expunge Assist process thus far. To create a better protected codebase, we want to retroactively implement tests.

Create tests for the below scenarios. Feel free to include additional tests if you find opportunities for more coverage.

Action Items

  • progress bar sets up correctly
    • progress bar renders
  • progress bar displays correct percentage based on value input
    • not sure about this one

Resources/Notes

Jest
React Testing Library

@sydneywalcoff sydneywalcoff added role: development anything related to code feature: technical standards accessibility, usability, unit testing, etc. labels Mar 15, 2024
@sydneywalcoff sydneywalcoff added this to the Launch Prep 2.0 milestone Mar 15, 2024
@sydneywalcoff sydneywalcoff added priority: low size: 3pt Can be done in 13-18 hours front-end type of development task relating to the website DevOps type of development task related to Process, Github Actions, and Deployment draft Not yet ready to be worked on issue level I: request Smallest type of issue; Typically can be completed by one person dependency The issue or reason why this issue is in the icebox and removed draft Not yet ready to be worked on labels Mar 20, 2024
@sydneywalcoff sydneywalcoff mentioned this issue Mar 21, 2024
14 tasks
@sydneywalcoff sydneywalcoff removed the dependency The issue or reason why this issue is in the icebox label Mar 27, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this to Prioritized Backlog in P: EA: Project Board Jun 14, 2024
Copy link

Hey @whitneywind! Thanks for taking this issue.

To help keep everyone in the loop, please comment your Estimated Time to Completion (ETC) below!

Thanks again!

@whitneywind
Copy link
Member

@sydneywalcoff I'm still working on this one, but I could use clarification about the progression of the progress bar. So far my tests show that it works correctly and renders at the corresponding percentage that gets passed in. For some reason though the percentage props it's being given are not proportional. Should that be fixed or was it intended to increase like this?

Screenshot 2024-10-21 at 7 24 01 PM

Copy link

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@whitneywind
Copy link
Member

I'm still working on this issue. I need clarification about the desired behavior and then I'll be able to proceed.

Copy link

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@whitneywind
Copy link
Member

I'm working on making the requested changes and should finish up this week!

@sydneywalcoff sydneywalcoff mentioned this issue Jan 6, 2025
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in P: EA: Project Board Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps type of development task related to Process, Github Actions, and Deployment feature: technical standards accessibility, usability, unit testing, etc. front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person priority: low role: development anything related to code size: 3pt Can be done in 13-18 hours Status: Update Requested
Projects
Development

Successfully merging a pull request may close this issue.

3 participants