feat(resolution): Expand media query support #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obartra
force-pushed
the
obartra/add-device-width-defaults
branch
2 times, most recently
from
a8222f2 to
f19590e
Compare
obartra
force-pushed
the
obartra/add-device-width-defaults
branch
2 times, most recently
from
ec092cf to
143ace6
Compare
- Lower the min width to account for iPhone 5 resolution
- Add support for OR logic within displayAliases
- This is to support applying a media query when either the screen or the device
with are within certain values
BREAKING CHANGE layout defaults change
obartra
force-pushed
the
obartra/add-device-width-defaults
branch
from
2d44ccd to
07da9a7
Compare
andrewmtoy
approved these changes
Feb 19, 2018
| return ( | ||
| <ConfigProvider displayAliases={displayAliases}> | ||
| <Grid justify="center"> | ||
| <Grid show="test" style={colors.colors1} margin="L" size={6}> |
There was a problem hiding this comment.
What do you think about renaming show to showWhen?
There was a problem hiding this comment.
If we want to make changes to the resolution api now is the time (I think only PES is using it)
Since this is part of the existing API, if we change it I wouldn't make it as part of this PR but we can update it
arahansen
approved these changes
Feb 19, 2018
|
🎉 This PR is included in version 16.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with are within certain values
Tasks
BREAKING CHANGE layout defaults change
Closes #367
Closes #366