fix(layout): IE11 grid fix #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obartra
force-pushed
the
obartra/ie11
branch
6 times, most recently
from
eec5d35 to
dc6eff5
Compare
- Story was using problematic css properties: https://github.com/philipwalton/flexbugs#flexbug-17
|
🎉 This PR is included in version 16.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was not with gymnast but with the custom css used in the report example. Browsing through the diffs I don't see other issues but it may be a good idea to try to reduce the tolerance threshold (now at 3.7%).
I haven't tested it but I suspect part of it will require setting font-size to 0px on CI (not just transparent)
Closes #233