Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce minimum Python version #17

Open
1 of 7 tasks
gy-mate opened this issue Oct 5, 2024 · 0 comments
Open
1 of 7 tasks

Enforce minimum Python version #17

gy-mate opened this issue Oct 5, 2024 · 0 comments
Assignees
Labels
blocked Issues blocked by other (upstream) issues enhancement New feature or request publishing Issues regarding how the app is distributed

Comments

@gy-mate
Copy link
Owner

gy-mate commented Oct 5, 2024

Description

If the requires-python Trove classifier in pyproject.toml is ignored and package is ran with Python <3.12, the following error occurs at the end of the process:

Image

Reported by @TancsicsGergely on Discord

Version

2.0.2

Preferred solution

Build backends (pipx and shiv uses setuptools) should fail when building moodle-to-vikwikiquiz with a Python version that doesn't meet the requires-python Trove classifier.

Related: pypa/pipx#387

To implement this, submitting a PEP was hinted at by a CPython developer. The steps for this are:

Alternatives considered

Using sys.version_info to check the interpreter version. I think this isn't a good idea because it would require updating the minimum Python version in two separate files.

@gy-mate gy-mate added the enhancement New feature or request label Oct 5, 2024
@gy-mate gy-mate self-assigned this Oct 5, 2024
@gy-mate gy-mate added publishing Issues regarding how the app is distributed blocked Issues blocked by other (upstream) issues labels Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issues blocked by other (upstream) issues enhancement New feature or request publishing Issues regarding how the app is distributed
Projects
Status: to do
Development

No branches or pull requests

1 participant