Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile-time configuration to disable rpc.enhancedClasses feature #9881

Open
niloc132 opened this issue Dec 20, 2023 · 0 comments
Open

Compile-time configuration to disable rpc.enhancedClasses feature #9881

niloc132 opened this issue Dec 20, 2023 · 0 comments

Comments

@niloc132
Copy link
Contributor

Following #9709 and the PR #9879 to mitigate this by disabling the feature, this issue is to track efforts to entirely disable it. This would allow projects to safely leave JDO/JPA annotations in their DTO sources, without needing to filter or sign/verify requests and responses.

At GWT compile time, some hint would tell the GWT-RPC codegen to not only leave the @ClientFields code out of the serialization policy, but avoid generating client code to handle those enhanced payloads. This should amount to little more than ensuring that JClassType.isEnhanced() or TypeInfoComputed.maybeEnhanced() always return false in these cases.

Disabling this could be by annotations on the DTO type itself, on the RemoteService type that the policy file would pertain to, or perhaps globally, with something like a "deny" to match the "allow" that the rpc.enhancedClasses configuration property currently allows (perhaps with wildcards, rather than excluding on a class-by-class basis).

By excluding the ClientFields directive entirely from the serialization policy file, the changes made in #9879 would never need to warn/error about these types at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant