-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling skygrids at the workflow level #4963
Comments
I started looking at where to change the code and I realised that even generating injections will have to take into account the sky uncertainty. @sebastiangomezlopez told me that @MarcoCusinato and @Thomas-JACQUOT both brought this up on a call. |
@pannarale in my view, the sky location of injections would be handled directly by drawing the distribution for |
@pannarale, @titodalcanton brought up the idea of appending the sky type and |
Note to self: we can remove |
This was done in #4985, is anything more needed? |
Correct. This can be closed. |
Even though the skygrid functionalities have been implemented inside pycbc_multi_inspiral, at the moment we can not pass skygrids as input when generating PyGRB workflows.
Unlike our initial tests on GRB170817A, where a single point in the grid is enough. We need this implementation for GRBs that are poorly resolved in the sky.
The text was updated successfully, but these errors were encountered: