From 215d5485a61e6070615bb29197e9798aef0d2ab1 Mon Sep 17 00:00:00 2001 From: Ian Harry Date: Thu, 1 Sep 2022 05:58:50 -0700 Subject: [PATCH] FIx modulus issue --- pycbc/events/eventmgr_cython.pyx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pycbc/events/eventmgr_cython.pyx b/pycbc/events/eventmgr_cython.pyx index 30b36fe019c..bf51ab00270 100644 --- a/pycbc/events/eventmgr_cython.pyx +++ b/pycbc/events/eventmgr_cython.pyx @@ -66,6 +66,9 @@ def logsignalrateinternals_computepsignalbins( for idx in range(length): ridx = rtype[idx] pdif[idx] = (pref[ridx] - p[ridx]) % (M_PI * 2) + if pdif[idx] < 0: + # C modulus operator is not same as python's, correct for this + pdif[idx] += (M_PI * 2) tdif[idx] = shift[ridx] * to_shift_ref + tref[ridx] - shift[ridx] * to_shift_ifo - t[ridx] sdif[idx] = (s[ridx] * sense * sqrt(sigref[ridx])) / (sref[ridx] * senseref * sqrt(sig[ridx]))