Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimPreviewHashFarm breaks concatenation test #78

Closed
c-blake opened this issue Jul 3, 2024 · 3 comments · Fixed by #80
Closed

nimPreviewHashFarm breaks concatenation test #78

c-blake opened this issue Jul 3, 2024 · 3 comments · Fixed by #80

Comments

@c-blake
Copy link

c-blake commented Jul 3, 2024

The error more specifically is this one:

tests/test_ziparchives_read.nim(46, 5) `entry == entries[numEntries]`

I don't understand why zip file catenation would depend upon string hasher order, but it is one of a couple things holding up activating nimPreviewHashFarm by default. So, if you could look into it soon, that would be awesome.

@guzba
Copy link
Owner

guzba commented Jul 3, 2024

The issue here is that the test assumed the Table order was stable, but really I should use OrderedTable. I'll have a fix for this tagged in a little bit.

@guzba guzba closed this as completed in #80 Jul 3, 2024
@guzba
Copy link
Owner

guzba commented Jul 3, 2024

@c-blake
Copy link
Author

c-blake commented Jul 3, 2024

Thanks, for the quick work, man, esp. for the rapid release tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants