Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node 8 and Node 9 to continuous integration testing #494

Merged
merged 3 commits into from
Mar 6, 2018

Conversation

cooltoast
Copy link
Contributor

Hi @guyonroche,

I appreciate your work on this package! I use it regularly in different node environments, and I think using simple continuous integration would be very helpful for me (and possibly others) to understand this package's node compatibility, and for ensuring tests pass for pull requests and new features.

In a previous PR I've added a .travis.yml file that TravisCI can use. It's free of charge, and the good news is that the tests pass in Node versions 6-9!

Please consider activating this repo in TravisCI: https://docs.travis-ci.com/user/getting-started/
Upon the next pushed commit, it'll immediately build and run the tests you've written.

Thanks!

@cooltoast
Copy link
Contributor Author

Hi @guyonroche

Is there an issue with this PR? I see you've been merging PR's recently and just wanted to check in

@guyonroche
Copy link
Collaborator

Hi @cooltoast - I'm reviewing this PR right now - as mentioned, I am currently overworked with very little time to spare. I'm trying to set aside a little time each day to catch up with all the PRs... they kinda sneaked up on me!
Glad you like this lib :-)

@guyonroche guyonroche merged commit 2de05ef into exceljs:master Mar 6, 2018
@cooltoast
Copy link
Contributor Author

Hey @guyonroche thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants