Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SECURITY.MD documentation #68

Closed
zbjdonald opened this issue Sep 23, 2022 · 7 comments · Fixed by #69
Closed

Add SECURITY.MD documentation #68

zbjdonald opened this issue Sep 23, 2022 · 7 comments · Fixed by #69
Labels
documentation Improvements or additions to documentation question Further information is requested
Milestone

Comments

@zbjdonald
Copy link

No description provided.

@routerino routerino added documentation Improvements or additions to documentation question Further information is requested labels Sep 23, 2022
@routerino
Copy link
Contributor

Bearer token is saved to browser cache, which is about as much auth as you can have without a backend to facilitate it.

@routerino routerino changed the title Any user authentication? Add SECURITY.MD documentation Sep 23, 2022
@routerino routerino added this to the Next Release milestone Sep 23, 2022
@zbjdonald
Copy link
Author

Thank you. For example, vpn.xxxx.com is login url, vpn.xxxx.com/web can manage all tailscale client. I think vpn.xxxx.com/web need a login page, otherwise people who can visit vpn.xxxx.com also can manage all tailscale client.

@routerino
Copy link
Contributor

Try saving your API key and then opening an incognito window or a browser on another profile.

@zbjdonald
Copy link
Author

work as expected
Snipaste_2022-09-26_16-32-29

@joshuataylor
Copy link

If you want to stop random access to this page, you have a few options depending on what you use.

nginx: Use basic auth (easiest), or oauth through https://github.com/oauth2-proxy/oauth2-proxy

Caddy: Use basic auth, maybe https://github.com/greenpau/caddy-security/blob/main/README.md (Personally haven't tested this for Caddy).

@routerino
Copy link
Contributor

If you want to stop random access to this page, you have a few options depending on what you use.

nginx: Use basic auth (easiest), or oauth through https://github.com/oauth2-proxy/oauth2-proxy

Caddy: Use basic auth, maybe https://github.com/greenpau/caddy-security/blob/main/README.md (Personally haven't tested this for Caddy).

Mostly it should be irrelevant, as anything sensitive is saved to the local browser cache.

It's not ideal as if there's a security issue with the client code, it can cause leaks of sensitive data. However, this is mitigated by the fact that client code is effectively signed by the hash signature of the compiled code.

This isn't ideal and should be better served by a client-server model, but that is functionally impossible with a pure client side solution such as headscale-ui. This is a problem that needs to be solved via integration with headscale.

@joshuataylor
Copy link

yeah, i really don't see the point, unless you really don't want someone or a random bot to find it, but what are they going to do? 🤷

@routerino routerino linked a pull request Oct 12, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants