Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hakari: re-compilation problem about build-dependencies #83

Open
xxchan opened this issue Sep 17, 2023 · 1 comment
Open

hakari: re-compilation problem about build-dependencies #83

xxchan opened this issue Sep 17, 2023 · 1 comment

Comments

@xxchan
Copy link

xxchan commented Sep 17, 2023

By default, hakari will produce [build-dependencies] (I haven't learned why yet), but I found this will probably make a dependency compiled twice (under --release). This is because build-dependencies have different build profile configs

To compile quickly, all profiles, by default, do not optimize build dependencies

https://doc.rust-lang.org/cargo/reference/profiles.html#build-dependencies

@sunshowers Are you aware of this issue? I'm wondering what's the best practice. Is it better to remove build-dependencies in workspace-hack, or set profile.release.build-override 🤔

@sunshowers
Copy link
Member

Thanks for reporting this! That's definitely an annoying issue and I wasn't aware of it.

Hakari produces build dependencies because what it cares about is dependencies built on the host platform.

I don't plan to work on this unless my employer runs into it. However if you or someone else would like to think through and put together a plan, it would be really appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants