Bottom to top approach for list comprehension

[vkosuri]

With Referencing pull request comment #809 (comment)

Yes, I agree with @gunthercox comment, readability 👀 is very important it will gives us many advantages for example

• Catching issues will be very easier and new develop/integration will become very easier.
• Etc.

Yes sometime it is necessary to pick response also, With some hacks the below formats are looking good to me, the method i named it here ⤴️ Bottom to top approach for list comprehension, will provide more readability 👀

I did some exercise on some examples, please provide your comments/suggestion on this.

# Find the closest matching known statement
for statement in statement_list:
    confidence = self.compare_statements(input_statement, statement)

    if confidence > closest_match.confidence:
        statement.confidence = confidence
        closest_match = statement

vs

# The bottom to top approach for list comprehension, gives more readability
closest_match_and_confidence = [
    [
        statement,
        self.compare_statements(input_statement, statement)
    ] for statement in statement_list
]

Some more examples

for statement in statement_list:
    for response in statement.in_response_to:
        responses.add(response.text)

vs

# The bottom down approach for list comprehension, gives more readability
[
    responses.add(response.text)
    for statement in statement_list
    for response in statement.in_response_to
]

If it is looks good I'll try to make a PR which discussed here #738

[gunthercox]

@vkosuri I agree that this formatting does improve the readability of the list comprehension. Feel free to create a pull request. 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.