From 4f154b8277da79b3d716a38bf19e5d24dc7ea0ea Mon Sep 17 00:00:00 2001 From: Blaine Bublitz Date: Mon, 26 Sep 2016 15:14:08 -0700 Subject: [PATCH] Update: Use clone-buffer module to clone buffers (ref #112) --- index.js | 2 +- lib/cloneBuffer.js | 7 ------- package.json | 3 ++- test/clone-buffer.js | 30 ------------------------------ 4 files changed, 3 insertions(+), 39 deletions(-) delete mode 100644 lib/cloneBuffer.js delete mode 100644 test/clone-buffer.js diff --git a/index.js b/index.js index dd58d59..fe04694 100644 --- a/index.js +++ b/index.js @@ -1,7 +1,7 @@ var path = require('path'); var clone = require('clone'); var cloneStats = require('clone-stats'); -var cloneBuffer = require('./lib/cloneBuffer'); +var cloneBuffer = require('clone-buffer'); var removeTrailingSep = require('remove-trailing-separator'); var isBuffer = require('buffer').Buffer.isBuffer; var isStream = require('is-stream'); diff --git a/lib/cloneBuffer.js b/lib/cloneBuffer.js deleted file mode 100644 index 89f09ed..0000000 --- a/lib/cloneBuffer.js +++ /dev/null @@ -1,7 +0,0 @@ -var Buffer = require('buffer').Buffer; - -module.exports = function(buf) { - var out = new Buffer(buf.length); - buf.copy(out); - return out; -}; diff --git a/package.json b/package.json index 061d68e..09a8865 100644 --- a/package.json +++ b/package.json @@ -12,10 +12,11 @@ ], "dependencies": { "clone": "^1.0.0", + "clone-buffer": "^1.0.0", "clone-stats": "^1.0.0", "cloneable-readable": "^0.5.0", - "remove-trailing-separator": "^1.0.1", "is-stream": "^1.1.0", + "remove-trailing-separator": "^1.0.1", "replace-ext": "^1.0.0" }, "devDependencies": { diff --git a/test/clone-buffer.js b/test/clone-buffer.js deleted file mode 100644 index 95ecdf6..0000000 --- a/test/clone-buffer.js +++ /dev/null @@ -1,30 +0,0 @@ -'use strict'; - -var expect = require('expect'); - -var cloneBuffer = require('../lib/cloneBuffer'); - -describe('cloneBuffer()', function() { - - it('returns a new Buffer reference', function(done) { - var testBuffer = new Buffer('test'); - var testBuffer2 = cloneBuffer(testBuffer); - - expect(testBuffer2).toExist(); - expect(testBuffer2).toBeA(Buffer); - expect(testBuffer2).toNotBe(testBuffer); - done(); - }); - - it('does not replicate modifications to the original Buffer', function(done) { - var testBuffer = new Buffer('test'); - var testBuffer2 = cloneBuffer(testBuffer); - - // Test that changes dont modify both pointers - testBuffer2.write('w'); - - expect(testBuffer.toString('utf8')).toEqual('test'); - expect(testBuffer2.toString('utf8')).toEqual('west'); - done(); - }); -});