Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type definitions #38

Open
demurgos opened this issue May 8, 2018 · 2 comments
Open

Add type definitions #38

demurgos opened this issue May 8, 2018 · 2 comments

Comments

@demurgos
Copy link
Member

demurgos commented May 8, 2018

I'd like to use this library as a dependency of a Typescript project but there are no type definitions currently (even on DT) so it's harder to integrate. It would be nice add types here. (See my plugin-error issue for other reasons it may be a good idea).

Having the types here would also allow the Gulp type definitions to pull its watch options from here instead of redefining them downstream.

I'll send a PR myself to fix this issue (probably after gulpjs/async-done#47 is merged). Given that the library is very short it may also be possible to just convert it to TS and generate the types.

@phated
Copy link
Member

phated commented May 13, 2018

@demurgos I'm open to typings but not sure how I feel about rewriting the code in typescript. If we were going to rewrite in a language, it'd probably be ReasonML (which can also generate typescript definitions).

@demurgos
Copy link
Member Author

Ok, I'll just send typings then.

@phated phated added this to post-v5 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants