-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3750 - MouseEnter
/Leave
#3751
Conversation
I think the shadow button shouldn't move to the right, like as it isn't moving to the bottom, when it's pressed. Only the shadow effect should be hidden when the button is pressed. In my opinion the button is always in the same place and only the light is placed on top/left side chaining a shadow on the bottom/right. If the light is projected in others directions the shadows will be propagate accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting reviewing this wit some observations. If necessary I'll will add more.
My opinion is the current effect looks great. This was discussed here: And the code has this comment: It would be trivial to add a CM property to control this, but we'd still need to have a default. I enabled the effect by default in this PR so that it was in everone's face and we could get good debate going. The right place to further opine on it is here: |
Renamed ColorName to ColorName16 to make it clear it's purpose. Added related TODOs.
I already noted that unit tests are extremely slow in this PR. |
Fixed. |
These two images bellow refer to the same inline data in the
|
I've decided to rebase
v2_2491->Overlapped
, which was here:Overlapped
Design, mouse/keyboard sizing - Progress on #2491 #3705... onto this PR given this PR is dependent on it. This will make is so there's only one big PR merging into v2_develop.
Fixes
Toplevel
- IntroduceRunnable
andOverlapped
instead #2491 byViewArrangement.Overlapped
supportSlider
: API for setting options is clunky #3735Adornments
#3406MouseEnter/Leave
is broken for Views with subviews #3750MouseEvent
andMouseEventEventArgs
to simplify #3029Proposed Changes/Todos
OnDrawContent
and get z-order correct.Bars
scenario to illustrate Popover menu conceptNavigation
scenario withArrangementEditor
; likeAdornmentEditor
makes it wasy to change view settings related to arrangement for testing/demos.Navigation
scenario toArrangement
scenario - one for eachViewArrangement.Resizable
Draw
Toplevel
- See how far I can get in removingToplevel
allogether without re-doing all theRunnable
stuff (for a later PR focused onIRunnable
).docfx/docs
and other API docsFindDeepestView
intoGetViewsUnderMouse
. ->GetViewsUnderMouse ().LastOrDefault ()
is equivalent toFindDeepestView
MouseEnteredView
toList <View?>? ViewsUnderMouse
Application.RaiseMouseEnterLeaveEvents ()
called byOnMouseEvent
- managesViewsUnderMouse
and raises events as appropriate.Mouse
Scenario to really stressGetViewsUnderMouse
and eventsGetViewsUnderMouse
Mouse
scenario.MouseEvent
params fromMouseEnter/Leave
events; there's no need for them.MouseEnter
should be cancellable. Yes.ViewDiagnostics.Hover
Color
handling to exclusively useColorStrings
instead of legacy ColorName values.For future PRs
Runnable
conceptTabStop
Editor #3742Popover
- A consistent way of enabling a Subview to popup outside of a View #3691Cursor
handling per./docfx/docs/cursor.md
#3444MenuBar
andStatusBar
can be in any View, even multiple.Adornments
that are notViewArrangement.Fixed
are not supported #3743TileView
- UseLineCanvas
to draw borders and auto-join borders #2483Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)