Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3700. ContextMenu pollutes Toplevel.MenuBar's key bindings #3709

Merged
merged 8 commits into from
Sep 2, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Aug 30, 2024

Fixes

Proposed Changes/Todos

  • Remove static from the MenuItem _menuBar field
  • Only populate the ContextMenu keybindings when call the Show method.
  • Add #nullable enable to MenuBar, Menu, MenuBarItem, MenuItem and ContextMenu
  • Adapt the Views and Scenarios to use the changed ContextMenu

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner August 30, 2024 22:32
@BDisp BDisp marked this pull request as draft August 31, 2024 15:49
@BDisp BDisp marked this pull request as ready for review September 1, 2024 19:20
@tig tig merged commit fa0085d into gui-cs:v2_develop Sep 2, 2024
4 checks passed
@BDisp BDisp deleted the v2_3700_contextmenu-keybindings-fix branch September 2, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContextMenu pollutes Toplevel.MenuBar's key bindings
2 participants