Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2537, #3691, #3406 - New Overlapped Design, mouse/keyboard sizing - Progress on #2491 #3705

Closed
wants to merge 56 commits into from

Conversation

tig
Copy link
Collaborator

@tig tig commented Aug 30, 2024

Fixes

Proposed Changes/Todos

  • Remove temporary code in OnDrawContent and get z-order correct.
  • Enhance Bars scenario to illustrate Popover menu concept
  • Enhance Navigation scenario with ArrangementEditor; like AdornmentEditor makes it wasy to change view settings related to arrangement for testing/demos.
  • Clone Navigation scenario to Arrangement scenario - one for each
  • Implement support for ViewArrangement.Resizable
  • Fix Draw
  • Remove more code from Toplevel - See how far I can get in removing Toplevel allogether without re-doing all the Runnable stuff (for a later PR focused on IRunnable).
  • Fix Add mouse/keyboard resizing of views #2537
  • Update docfx/docs and other API docs

For future PRs

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig self-assigned this Aug 30, 2024
@tig tig changed the title Partially Addresses #2491 - New Overlapped Design Fixes #2537, #3691 - Progress on #2491 - New Overlapped Design, mouse/keyboard sizing, and Popover Aug 30, 2024
@tig tig mentioned this pull request Sep 10, 2024
4 tasks
@tig tig changed the title Fixes #2537, #3691 - Progress on #2491 - New Overlapped Design, mouse/keyboard sizing Fixes #2537, #3691, #3406 - New Overlapped Design, mouse/keyboard sizing - Progress on #2491 Sep 18, 2024
@tig tig marked this pull request as ready for review September 19, 2024 18:04
@tig tig mentioned this pull request Sep 24, 2024
37 tasks
@tig
Copy link
Collaborator Author

tig commented Sep 24, 2024

Closing. This branch is now rebased with

@tig tig closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment