Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3702. Manipulating Adornment doesn't always cause LayoutSubviews. #3704

Merged
merged 4 commits into from
Aug 31, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Aug 29, 2024

Fixes

Proposed Changes/Todos

  • Force layout at once before calculate all the subviews.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner August 29, 2024 17:07
Terminal.Gui/View/Layout/DimAuto.cs Outdated Show resolved Hide resolved
@tig tig merged commit 9251244 into gui-cs:v2_develop Aug 31, 2024
4 checks passed
@BDisp BDisp deleted the v2_3702_dim-auto-layout-fix branch August 31, 2024 22:28
@BDisp BDisp restored the v2_3702_dim-auto-layout-fix branch August 31, 2024 22:29
@BDisp BDisp deleted the v2_3702_dim-auto-layout-fix branch August 31, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manipulating Adornment doesn't always cause LayoutSubviews
2 participants