Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3698. ResourceManager GetResourceSet doesn't fallback to default for no translated keys. #3699

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Aug 27, 2024

Fixes

Proposed Changes/Todos

  • Add internal ResourceManagerWrapper class.
  • Add GlobalResources class helper which will handle the ResourceManagerWrapper. I advice to use the static GlobalResources to deal with all Strings resources.
  • Add a new GetResourceSet method with a adicional parameter filter Func<DictionaryEntry, bool>?.
  • Add ResourceManagerTests file with unit tests.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner August 27, 2024 19:57
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. See formatting comment.

Terminal.Gui/Drawing/ColorStrings.cs Show resolved Hide resolved
@tig tig merged commit c97e412 into gui-cs:v2_develop Aug 28, 2024
4 checks passed
@BDisp BDisp deleted the v2_3698_resourcemanager-wrapper-new branch August 28, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResourceManager GetResourceSet doesn't fallback to default for no translated keys.
2 participants