Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 fix warnings #3671

Merged
merged 14 commits into from
Aug 19, 2024
Merged

V2 fix warnings #3671

merged 14 commits into from
Aug 19, 2024

Conversation

tig
Copy link
Collaborator

@tig tig commented Aug 19, 2024

Fixes

  • Fixes a bunch of build warnings

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig marked this pull request as ready for review August 19, 2024 15:22
@tig tig requested a review from BDisp August 19, 2024 15:22
@BDisp
Copy link
Collaborator

BDisp commented Aug 19, 2024

@tig it's only a question. Should the Application.Name should be concise with others, like ApplicationNavigation and ApplicationOverlapped?

image

@tig
Copy link
Collaborator Author

tig commented Aug 19, 2024

@tig it's only a question. Should the Application.Name should be concise with others, like ApplicationNavigation and ApplicationOverlapped?

image

ApplicaitonNavigation and ApplicationOverlapped are classes.

@tig tig merged commit b267e16 into gui-cs:v2_develop Aug 19, 2024
3 checks passed
@dodexahedron
Copy link
Collaborator

🙏

Yay.

We'll have a bunch more to address later on, too, as we should turn up the analysis to a higher level before release.

IMO, beta is a good time for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants