Fixes #3667. Null reference in v2 in FindDeepestView. #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tig
approved these changes
Aug 19, 2024
| /// <summary>Gets or sets the menu for this Toplevel.</summary> | ||
| public MenuBar? MenuBar { get; set; } | ||
| /// <summary>Gets the latest <see cref="MenuBar"/> added into this Toplevel.</summary> | ||
| public MenuBar? MenuBar => (MenuBar?)Subviews?.LastOrDefault (s => s is MenuBar); |
There was a problem hiding this comment.
For future cases like this, using the safe cast form (thingThatMightBeNull as ExpectedType) is a better pattern than an explicit cast.
There was a problem hiding this comment.
Also, you can use the generic form of the methods instead of explicit checking, and avoid the whole thing:
public MenuBar? MenuBar => Subviews?.OfType<MenuBar>().LastOrDefault ();| /// <summary>Gets or sets the menu for this Toplevel.</summary> | ||
| public MenuBar? MenuBar { get; set; } | ||
| /// <summary>Gets the latest <see cref="MenuBar"/> added into this Toplevel.</summary> | ||
| public MenuBar? MenuBar => (MenuBar?)Subviews?.LastOrDefault (s => s is MenuBar); |
There was a problem hiding this comment.
Also, you can use the generic form of the methods instead of explicit checking, and avoid the whole thing:
public MenuBar? MenuBar => Subviews?.OfType<MenuBar>().LastOrDefault ();
|
Also, you can use the generic form of the methods instead of explicit checking, and avoid the whole thing:
I prefer this one. Thanks. |
|
Yep. Nice stuff in there for use cases like this. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes/Todos
Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)