Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3664. Shortcut crashes in SetColors #3666

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Fixes #3664. Shortcut crashes in SetColors #3666

merged 1 commit into from
Aug 17, 2024

Conversation

tig
Copy link
Collaborator

@tig tig commented Aug 17, 2024

Fixes

Proposed Changes/Todos

  • Added unit test
  • Fixed bug

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig requested a review from tznind August 17, 2024 15:08
@tig tig merged commit c00290f into gui-cs:v2_develop Aug 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BDisp BDisp BDisp approved these changes

@tznind tznind Awaiting requested review from tznind

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shortcut crashes when removed from SuperView and ColorScheme set to null
2 participants
@tig @BDisp