Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated migration doc to include additional findings. #3660

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Updated migration doc to include additional findings. #3660

merged 4 commits into from
Aug 19, 2024

Conversation

dasien
Copy link
Contributor

@dasien dasien commented Aug 14, 2024

Fixes

  • Fixes #_____

Proposed Changes/Todos

  • Todo 1

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@dasien dasien requested a review from tig as a code owner August 14, 2024 15:54
tig
tig requested changes Aug 14, 2024
View reviewed changes
docfx/docs/migratingfromv1.md Outdated Show resolved Hide resolved
docfx/docs/migratingfromv1.md Outdated Show resolved Hide resolved
@tig tig merged commit a82636a into gui-cs:v2_develop Aug 19, 2024
BDisp pushed a commit to BDisp/Terminal.Gui that referenced this pull request Aug 19, 2024
@dasien @tig @BDisp
Updated migration doc to include additional findings. (gui-cs#3660)
c5be71b 
* Updated migration doc to include additional findings.

* Updated per PR recommendations.

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
tig added a commit that referenced this pull request Aug 19, 2024
@BDisp @tig @dasien
Fixes #3635. Focus gets confused with ContextMenu. (#3663)
a0c03b1 
* Fixes #3635. Focus gets confused with ContextMenu.

* Improving unit test.

* Updated migration doc to include additional findings. (#3660)

* Updated migration doc to include additional findings.

* Updated per PR recommendations.

---------

Co-authored-by: Tig <tig@users.noreply.github.com>

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
Co-authored-by: Brian Gentry <bgentry@trestledevelopment.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BDisp BDisp BDisp left review comments

@tznind tznind tznind left review comments

@tig tig tig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dasien @tig @BDisp @tznind