Fixes #3557: Mostly non-impacting minor changes to the csproj, a fix for nuget.config, and some design-time QoL stuff #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dodexahedron
added
work-in-progress
build-and-deploy
|
Also, all or at least most of this stuff will be drop-in portable to v1, as well, if you want. |
|
OK actually I will put in an issue, because there's one that touches the nuget.config file to fix bad sourcelink behavior for local command line builds. |
dodexahedron
changed the title
dodexahedron
changed the title
|
Think I'm done with this one. Zero warnings in the build output for the analyzer projects, now, as I addressed several and suppressed others that were just noise due to intentional naming and such. |
|
Yep. Ready to go. Yes, there's more to be done to the project files, but that's in different branches and targeting more specific things and will be in different PRs. |
The ReSharper additions, especially. If you keep caches local to the solution, that's a big one.
AllowUnsafe... was a duplicate and the comments were slightly off
Solution filter that is only what's required to build and test Terminal.Gui
This is a visual studio dependency map. It lists the components needed to be able to build the solution. It can be fed to the VS installer to ensure that, at minimum, the listed components (and their dependencies) are installed, so nobody has to guess what's needed.
Doesn't affect the actual file paths.
Lower because at least most of the docs use lower. Not all, but I went with what looked most common. More casing
dodexahedron
force-pushed
the
v2_dodex_solution_and_project_QoL_tweaks_1
branch
from
9c6ff54
to
2e2170e
Compare
|
Re-based on v2_develop as of a little while ago |
tig
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Aside from that, mostly a few tweaks to the csproj files and other build-related stuff that don't really change anything but are a common base for a couple of branches I have open right now.
Well... Actually one does change/fix a minor thing - configuration conditions have the AnyCPU part removed, so all architectures get those properties, even if an explicit platform is given to the compiler.
This also brings in a couple of solution filters, which you can optionally use both as what you open in Visual Studio or what you target a build at, which don't change the .sln file, but just reduce what's actually loaded into the solution, if you use them. Very handy for making Visual Studio run a bit faster, if you're not wanting to load ALL the projects, and provides consistent templates for people to use, instead of relying on local non-tracked user preference files.
Also useful at build time, for release builds, to speed things up by not making MSBuild and nuget have to figure out everything for projects that aren't part of the build.
This also resolved all warnings in projects in the Analyzers folder.
Proposed Changes/Todos
Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)Just tossing this up while I finish cherry-picking bits from a couple of branches that form a nice common base.