Fixes #3381. WindowsDriver spurious ButtonPressed mouse events

[tig]

Fixes

• Fixes WindowsDriver emits spurious Button press mouse events #3381

Proposed Changes/Todos

• Diagnose - Between instantiations of WindowsDriver, if a double-click event was the last event, ReadConsole is retriving a spurious event with Button1Pressed.
• Update Mouse Scenario to illustrate
• Hack fix: In Teardown eat any outstanding ReadConsole input.

[BDisp]

I think you can also dispose the _waitForProbe.

In the TearDown uncomment:

_waitForProbe?.Dispose ();

In the WindowsInputHandler replace this in the finally:

            finally
            {
                if (!_inputHandlerTokenSource.IsCancellationRequested)
                {
                    _waitForProbe.Reset ();
                }
            }

[BDisp]

I think you can also dispose the _waitForProbe.

In the TearDown uncomment:

_waitForProbe?.Dispose ();

In the WindowsInputHandler replace this in the finally:

            finally
            {
                if (!_inputHandlerTokenSource.IsCancellationRequested)
                {
                    _waitForProbe.Reset ();
                }
            }

The reason for this is when IsCancellationRequested is true the finally section is only executed when the _waitForProbe is disposed.

[BDisp]

LGTM. I only recommend the changes in #3382 (comment).

[tig]

I think you can...

I'm leery of making these changes.

They make sense to me but I don't have the time right now to really think it through. How confident are you these changes are correct?

[tig]

We can fix those issues in another PR.