Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1720 - ColorPicker pop up example (in ProgressBarStyles Scenario) #3154

Merged
merged 8 commits into from
Jan 13, 2024

Conversation

tig
Copy link
Collaborator

@tig tig commented Jan 10, 2024

Fixes

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp
Copy link
Collaborator

BDisp commented Jan 10, 2024

How about popup near the respective buttons on available space (below, up, right, left) as the ContextMenu does?

@tig
Copy link
Collaborator Author

tig commented Jan 10, 2024

How about popup near the respective buttons on available space (below, up, right, left) as the ContextMenu does?

Yea, that's a bug. I'll fix.

@tig tig changed the title Fixes #1720 - ColorPicker pop up example Fixes #1720 - ColorPicker pop up example (in ProgressBarStyles Scenario) Jan 11, 2024
@tig
Copy link
Collaborator Author

tig commented Jan 11, 2024

WindowsTerminal_mEERHWNnTu.mp4

@BDisp
Copy link
Collaborator

BDisp commented Jan 11, 2024

@tig in my opinion if you click on the Foreground button the popup should appear bellow the bottom of the button. See the case of the ContextMenu:

image

Or above the top of the button:

image

@tig
Copy link
Collaborator Author

tig commented Jan 11, 2024

@tig in my opinion if you click on the Foreground button the popup should appear bellow the bottom of the button. See the case of the ContextMenu:

100% agree.

I am not going to spend the time now implementing this in ProgressBarStyles.cs.

Instead, it should be a built-in feature as part of

@BDisp
Copy link
Collaborator

BDisp commented Jan 11, 2024

100% agree.

I am not going to spend the time now implementing this in ProgressBarStyles.cs.

Instead, it should be a built-in feature as part of

Of course that this have more sense for a built-in generic popup that can be popup by any view and with any view content inside the popup.

@tig tig merged commit d54461f into gui-cs:v2_develop Jan 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants