Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3106: Combo Box selection fixes #3117

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

MaciekWin3
Copy link
Contributor

@MaciekWin3 MaciekWin3 commented Jan 3, 2024

Fixes #3106 - The bug occurred because we were searching for an item in the entire collection instead of the filtered set. Additionally, I introduced a feature that deselects the previously selected item when the search text is shorter than the previous one. This ensures proper cleanup after the previous search.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@MaciekWin3 MaciekWin3 requested a review from tig as a code owner January 3, 2024 23:44
@tig tig merged commit 3d829d7 into gui-cs:v2_develop Jan 4, 2024
1 check passed
@fergusonr
Copy link
Contributor

@MaciekWin3 Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants