Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2800 - Revamp ColorPicker and Color Scenarios in UICatalog #2900

Closed
wants to merge 49 commits into from

Conversation

tig
Copy link
Collaborator

@tig tig commented Oct 12, 2023

Fixes #2800 - Revamp ColorPicker and Color Scenarios in UICatalog

Depends on #2896

  • ColorPicker View let's users pick
    • From the legacy 16-colors
    • From the full palette of 24-bit colors
      • Using RGB
      • Using HSL
  • ColorPicker Scenario sufficiently demonstrates all of the above
  • True Colors Scenario shows 16-colors correctly
    • When Force16Colors is true

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig changed the title Fixes #2800 - Revamp ColorPicker and Color Scenarios in UICatalog Fixes #2800 - Revamp ColorPicker and Color Scenarios in UICatalog Oct 12, 2023
@tznind
Copy link
Collaborator

tznind commented Jul 11, 2024

When I check this branch out I get lots of errors around Analyzers e.g.

I have tried clean and rebuild but nothing. Any ideas?

Ok solution was just to merge v2_develop into this branch locally.

@tig
Copy link
Collaborator Author

tig commented Aug 28, 2024

Superceded by #3604

@tig tig closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp ColorPicker and Color Scenarios in UICatalog
2 participants