Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2493. Move all layout code out of View (and Toplevel) into a layout helper class #2544

Merged
merged 13 commits into from
Apr 14, 2023

Conversation

tig
Copy link
Collaborator

@tig tig commented Apr 14, 2023

Fixes #2493 - Move all layout code out of View (and Toplevel) into a layout helper class
Fixes # - Renames Mdi to Overlapped; reorganzies Overlapped related code in prep for #2502
Fixes a ton of API Docs.
Renames unclear APIs.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig added the v2 For discussions, issues, etc... relavant for v2 label Apr 14, 2023
@tig tig changed the title Fixes #2493 Fixes #2493. Move all layout code out of View (and Toplevel) into a layout helper class Apr 14, 2023
@BDisp
Copy link
Collaborator

BDisp commented Apr 14, 2023

@tig thanks for awesome work.

@tig tig marked this pull request as ready for review April 14, 2023 16:19
@tig tig requested a review from migueldeicaza as a code owner April 14, 2023 16:19
@tig
Copy link
Collaborator Author

tig commented Apr 14, 2023

@tig thanks for awesome work.

Hopefully this all helps us more easily maintain all this code!

You ok with the Mdi -> Overlapped rename?

@tig tig merged commit b4552ee into gui-cs:v2_develop Apr 14, 2023
@BDisp
Copy link
Collaborator

BDisp commented Apr 14, 2023

Hopefully this all helps us more easily maintain all this code!

For sure it will be.

You ok with the Mdi -> Overlapped rename?

It's fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 For discussions, issues, etc... relavant for v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants