Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1475. Selection ending with a white space error. #1478

Merged
merged 18 commits into from
Oct 25, 2021

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Oct 6, 2021

Added mouse triple click feature to the TextView to select full line.

text-selection

@En3Tho
Copy link
Contributor

En3Tho commented Oct 17, 2021

This looks awesome. I've also tested the copy-paste in Powershell in it works perfectly. I believe pasting is totally consistent now. Tripple click feature is super useful too :)

@En3Tho
Copy link
Contributor

En3Tho commented Oct 20, 2021

@BDisp @tig What prevents this from being merged? Can I help somehow?

@BDisp
Copy link
Collaborator Author

BDisp commented Oct 20, 2021

@BDisp @tig What prevents this from being merged? Can I help somehow?

I'm only a contributor and not depends on me.

@En3Tho
Copy link
Contributor

En3Tho commented Oct 20, 2021

I see. @migueldeicaza Can you please merge this? This adds useful features and fixes a bug in powershell pasting.

@En3Tho
Copy link
Contributor

En3Tho commented Oct 22, 2021

@tig Can this be merged?

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for delay.

@tig tig merged commit 58e7698 into gui-cs:main Oct 25, 2021
@BDisp BDisp deleted the textfield-textview-whitespace-fix branch October 26, 2021 16:31
@En3Tho
Copy link
Contributor

En3Tho commented Oct 26, 2021

@tig Thanks!

BDisp added a commit to BDisp/Terminal.Gui that referenced this pull request Nov 1, 2021
…#1478)

* Fixes gui-cs#1475. Selection ending with a white space error.

* Prevents the mouse  double click processing twice.

* Removing unnecessary variable.

* Sets ScrollViewBar CanFocus to false to ensure the host always focused.

* Only navigates through TabView if winDialog is not null and ensures TextView being focused.

* Fixes both dynamic menu and status bar broken scenarios.

* Fix a bug where the subviews oldEnabled can be overridden, even the superview Enable property hasn't changed.

* Fixes CanFocus when set to false and HasFocus is true.

* Fixes the broken TextView DesiredCursorVisibility.

* Prevents TextField being focused by mouse if CanFocus is false.

* Fixes the CanFocus on content views.

* Fixes gui-cs#1470. Not all WindowsConsole.InputRecord are caught in WindowsDriver.

* Changing the input for a Queue object.

* Suppress warnings.

* Fixed yet the visibility cursor and adding more unit tests.

* Suppressing more warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants