Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HighlightOnPress and/or WantContinousButtonPressed has issues with nested subviews. #3753

Open
tig opened this issue Sep 23, 2024 · 2 comments
Labels
Milestone

Comments

@tig
Copy link
Collaborator

tig commented Sep 23, 2024

In #3751 I refactored and fixed a bunch of issues around mouse and highlight.

I'm not going to fix this there, so I'm creating an issue for it:

In the new Mouse scenario below each view in the Enter/Leave Demo is the same class... nested subviews:

  • The root
    • One in the root's padding: inPadding
    • Subview: Sub1
    • Subview: Sub2

Right now WantContinousButtonPressed is true for ALL 4. But Highlight on Press is only enabled for the root.

Note how sub1 and sub2 are showing highlight when I press in the Viewport of the root? that should not be happening.

PQPZSes 1

@tig tig added the bug label Sep 23, 2024
@tig tig added this to the V2 Release milestone Sep 23, 2024
@BDisp
Copy link
Collaborator

BDisp commented Sep 23, 2024

Yes it's true, having many highlight effects at once, hurting the eyes.

@tig
Copy link
Collaborator Author

tig commented Sep 23, 2024

Yes it's true, having many highlight effects at once, hurting the eyes.

This is a demo intended to show all the highlights.

That's not what this issue is for.

@tig tig changed the title Highight on Press has issues with nested subviews. HighlightOnPress and/or WantContinousButtonPressed has issues with nested subviews. Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants