Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adornments = too many Views #3706

Open
tig opened this issue Aug 30, 2024 · 0 comments
Open

Adornments = too many Views #3706

tig opened this issue Aug 30, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@tig
Copy link
Collaborator

tig commented Aug 30, 2024

I knew this would happen and there'd be a time to pay the piper... I think that time has come.

When I designed Adornments I decide to not lazy create them. As a result every View has 4 Views (6 if ShadowStyle is enabled).

The memory footprint of this is not huge, but material.

There is a perf it on shutdown in DEBUG:

image

VIa UI Catalog:

image

As part of

We will need to refactor Adornments so that they are created lazily.

@tig tig added the bug label Aug 30, 2024
@tig tig added this to the V2 Release milestone Aug 30, 2024
@tig tig self-assigned this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant