Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapped broken on the v2_develop branch using the BackgroundWorkerCollection scenario. #3636

Closed
BDisp opened this issue Aug 3, 2024 · 7 comments
Assignees
Labels
Milestone

Comments

@BDisp
Copy link
Collaborator

BDisp commented Aug 3, 2024

Here is some of the issues after opening the scenario:

  • After pressing F9 to open the MenuBar the keys navigations doesn't. Only work with mouse.
  • After opening MenuBar->View->WorkerApp pressing F9 to opening the MenuBar the menu isn't position correctly. See image:

image

  • Press enter do Run Worker, again for Start and wait until the result Work list: is open. Press again F9 to open the MenuBar and again the menu isn't position correctly. Seems that the application assumes that the MenuBar is on the focused view (OverlappedChildren) and not on the Application.OverlappedTop.
  • Close the opened Work list: by clicking the Close button and an exception is throwed. See image:

image

  • Another situation is when pressing F9 to open the MenuBar and we click outside the menu on another toplevel, the menu stays opened and it must be closed to allows selecting the other toplevel.
WindowsTerminal_TdVRQUqJwa.mp4
@BDisp
Copy link
Collaborator Author

BDisp commented Aug 3, 2024

@tig maybe ou can fix this in the #3634?

@tig
Copy link
Collaborator

tig commented Aug 3, 2024

@tig maybe ou can fix this in the #3634?

BackgroundWorkerCollection will need to be rewritten with #3634. I do not understand the logic of that Scenario after hours of studying it. Maybe it's because threading confuses me in general.

What I would prefer is for you to rewrite it. I will let you know when progress on #3634 is far enough long for you to do this.

@tig tig assigned BDisp Aug 3, 2024
@tig tig added the bug label Aug 3, 2024
@tig tig added this to the V2 Release milestone Aug 3, 2024
@BDisp
Copy link
Collaborator Author

BDisp commented Aug 3, 2024

BackgroundWorkerCollection will need to be rewritten with #3634. I do not understand the logic of that Scenario after hours of studying it. Maybe it's because threading confuses me in general.

What I would prefer is for you to rewrite it. I will let you know when progress on #3634 is far enough long for you to do this.

It it's to rewrite as a Toplevel with Window as subviews I prefer to delete it at all, because it uses a different methodology. You need to distinguish overlapped subviews from overlapped toplevels. The threading has nothing to do with the issues. MenuBar has bugs. It seems sometimes that an open menu is hidden but not effectively closed which will cause navigation behaviors issues.

@tig
Copy link
Collaborator

tig commented Aug 4, 2024

BackgroundWorkerCollection will need to be rewritten with #3634. I do not understand the logic of that Scenario after hours of studying it. Maybe it's because threading confuses me in general.
What I would prefer is for you to rewrite it. I will let you know when progress on #3634 is far enough long for you to do this.

It it's to rewrite as a Toplevel with Window as subviews I prefer to delete it at all, because it uses a different methodology. You need to distinguish overlapped subviews from overlapped toplevels. The threading has nothing to do with the issues. MenuBar has bugs. It seems sometimes that an open menu is hidden but not effectively closed which will cause navigation behaviors issues.

Do you agree we need a good multi-threading example for v2.

@tig
Copy link
Collaborator

tig commented Aug 4, 2024

BackgroundWorkerCollection will need to be rewritten with #3634. I do not understand the logic of that Scenario after hours of studying it. Maybe it's because threading confuses me in general.
What I would prefer is for you to rewrite it. I will let you know when progress on #3634 is far enough long for you to do this.

It it's to rewrite as a Toplevel with Window as subviews I prefer to delete it at all, because it uses a different methodology. You need to distinguish overlapped subviews from overlapped toplevels. The threading has nothing to do with the issues. MenuBar has bugs. It seems sometimes that an open menu is hidden but not effectively closed which will cause navigation behaviors issues.

Do you agree we need a good multi-threading example for v2.

Oh, and I meant #2491 when I wrote #3634 above.

@BDisp
Copy link
Collaborator Author

BDisp commented Aug 4, 2024

Do you agree we need a good multi-threading example for v2.

The Threading scenario was created more for the threading examples. The BackgroundWorkerCollection was created to demonstrate more the MDI concept now called Overlapped. But I understand that the overlapped feature can work well with both concepts, although with different code:

  • With overlapped top and overlapped childs.
  • With overlapped top and subviews.

@tig
Copy link
Collaborator

tig commented Aug 6, 2024

Closing.

I've added ensuring we have a good "Multiple overlapped, MDI-like views" example in #2491.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants