Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackgroundWorkerCollection scenario is badly clearing invisible button. #2420

Closed
BDisp opened this issue Mar 15, 2023 · 5 comments
Closed

BackgroundWorkerCollection scenario is badly clearing invisible button. #2420

BDisp opened this issue Mar 15, 2023 · 5 comments
Labels
bug v2 For discussions, issues, etc... relavant for v2
Milestone

Comments

@BDisp
Copy link
Collaborator

BDisp commented Mar 15, 2023

The reason is the Start button is set to Visible=false before the window is loaded, causing clear an nonexistent button yet. To avoid this it's needed to set the ClearOnVisibleFalse = false, thus prevent the button been clearing when is set to invisible.

visible-clear-issue

BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Mar 15, 2023
@tig tig added the bug label Mar 16, 2023
@tig tig added this to the v1.10 milestone Mar 16, 2023
@tig tig added the v2 For discussions, issues, etc... relavant for v2 label Mar 16, 2023
tig added a commit that referenced this issue Mar 22, 2023
…x_2420

Fixes #2420. BackgroundWorkerCollection scenario is badly clearing invisible button.
@tig
Copy link
Collaborator

tig commented Apr 16, 2023

I can't tell if this is fixed or not because it appears I broke something else in this Scenario with #2544.

@BDisp
Copy link
Collaborator Author

BDisp commented Apr 16, 2023

I can't tell if this is fixed or not because it appears I broke something else in this Scenario with #2544.

Yes, it's broken. I fixed with the #2560.

@BDisp
Copy link
Collaborator Author

BDisp commented Apr 16, 2023

This issue is fixed by #2421. It seems the issues aren't automatically closed by the "Fixes #" prefix after they are merged.

@BDisp BDisp closed this as completed Apr 16, 2023
@tznind
Copy link
Collaborator

tznind commented Apr 16, 2023 via email

@BDisp
Copy link
Collaborator Author

BDisp commented Apr 16, 2023

Thanks for clarification @tznind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug v2 For discussions, issues, etc... relavant for v2
Projects
No open projects
Status: ✅ Done
Development

No branches or pull requests

3 participants