Cannot switch off 3D borders on MessageBox

[fergusonr]

3D borders are now on by default. Can explicitly turn them off for a Dialog but not a MessageBox

[BDisp]

A Dialog is designed to appear on the top of another top-level. So, if no 3D border is needed, then a Window must be used, in my opinion.

[tznind]

Has the border style changed between patches for MessageBox? If so we could add an overload to Show that takes a style parameter at the end?

Or add a static property to MessageBox class of BorderStyle which affects all dialogs shown?

[fergusonr]

Dialog and MessageBox have consistent default border styles (3D), but if I want to switch both off, I can do this with a Dialog, but there is no equivalent for MessageBox

var d = new Dialog ();
d.Border.Effect3D = false;

[tznind]

MessageBox is a static Factory/helper class for Dialog:

https://github.com/migueldeicaza/gui.cs/blob/28580de3c57fe4fc03ddef157f4c4cc879a5bda0/Terminal.Gui/Windows/MessageBox.cs#L164

I think it would be a nice enhancement to expand these static functions to allow custom border style (i.e. 3d or line). But we don't want to break the existing API so would need to think of an elegant way (e.g. a new overloaded method or a static setting in the MessageBox class itself).

[BDisp]

Yes is true. This must be implemented without breaking anything. Thanks to both.