Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse input delay in Windows Terminal #1477

Closed
Trolldemorted opened this issue Oct 4, 2021 · 6 comments
Closed

Mouse input delay in Windows Terminal #1477

Trolldemorted opened this issue Oct 4, 2021 · 6 comments

Comments

@Trolldemorted
Copy link

I just ran dotnet run --project UICatalog in a cmd, a powershell and a windows terminal powershell, and noticed a huge mouse input delay in the latter.

I guess that is not intended? Can I do something do make gui.cs programs run smoothly in the windows terminal?

@BDisp
Copy link
Collaborator

BDisp commented Oct 4, 2021

It's a bug that is causing the click event is not processing. Checkout the PR #1447 and test, please.

@Trolldemorted
Copy link
Author

That branch works significantly faster! However after pressing ctrl+q the bottom line (Caps: Off │ Num: Off │ Scroll: Off │ CTRL-Q Quit │ F10 Hide/Show Status Bar │ WindowsDriver) remains.

BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Oct 4, 2021
@BDisp
Copy link
Collaborator

BDisp commented Oct 4, 2021

@Trolldemorted I already fixed, please test. Thanks for reporting this.

@tig tig closed this as completed in d55ae77 Oct 5, 2021
BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Oct 5, 2021
…us. (gui-cs#1447)

* Fixes gui-cs#1446. Added more features to the Border and Toplevel focus.

* Prevents throwing exception on negative effect3DOffset values

* Ensures that a view can be focused.

* Only sets focus if it isn't disposing.

* Fixes ViewToScreen and DrawChildBorder Effect3D.

* Unit test for negative coordinates with the ViewToScreen method.

* Added Tab navigation feature to the Editor scenario.

* ComboBox cursonDownKey nullref fix (gui-cs#1472)

* added null guard to fix null ref when pressing keyDown inside combobox
Improved an error message when view cannot be found

* Added a unit test to ensure combobox can process all key events
Found and fixed a new nullref

* Found a new bug when source is already present and combobox is added to a top view

* searchSet is auto initialized to new List() now to make the code a little bit safer

* Fixes WindowsDriver HeightAsBuffer set to false. (gui-cs#1466)

* Bump ReportGenerator from 4.8.12 to 4.8.13 (gui-cs#1473)

Bumps [ReportGenerator](https://github.com/danielpalme/ReportGenerator) from 4.8.12 to 4.8.13.
- [Release notes](https://github.com/danielpalme/ReportGenerator/releases)
- [Commits](danielpalme/ReportGenerator@v4.8.12...v4.8.13)

---
updated-dependencies:
- dependency-name: ReportGenerator
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixes gui-cs#1445. Fixing more the Curses and WSL clipboard. (gui-cs#1448)

* Fixes gui-cs#1445. Fixing more the Curses and WSL clipboard.

* Fixing unit tests.

* Changing namespace.

* Fixes WSL2 clipboard unit test.

* Upgrades devcontainer with the MainLoop fix.

* Fixes pasting with no selection and with lines break.

* Prevents the event button click being fired after a button pressed with mouse move.

* Fixes the char [ not being processed.

* Added Application.QuitKey property to allow change the quitting application key. (gui-cs#1450)

* Added Application.QuitKey property to allow change the quitting application key.

* Fixes QuitKey unit test by reseting his value.

* Locks timeouts until is added.

* Fixes gui-cs#1467. AlternateForward/BackwardKey bypasses dialog modality (gui-cs#1468)

* Changed namespace.

* Fixing merge conflicts.

* Fixes mouse click issue.

* Removing windows resizing because buffer resizing is enough.

* Fixes gui-cs#1477. Mouse click and console bottom on Windows Terminal.

Co-authored-by: Igor Bagdamyan <37334640+En3Tho@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Oct 5, 2021
@Trolldemorted
Copy link
Author

Works like a charm!

Could you publish a new stable release with these fixes?

@BDisp
Copy link
Collaborator

BDisp commented Oct 6, 2021

Thanks. Only @migueldeicaza or @tig can do that.

@tig
Copy link
Collaborator

tig commented Oct 13, 2021

I'll get a new release out asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants