Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border improvement request. #1446

Closed
BDisp opened this issue Aug 27, 2021 · 1 comment
Closed

Border improvement request. #1446

BDisp opened this issue Aug 27, 2021 · 1 comment

Comments

@BDisp
Copy link
Collaborator

BDisp commented Aug 27, 2021

Massively impressive.

I do note that

* hit testing on shadows isn't quite right (I would expect when clicking on a shadow for it to NOT activate the view with the shadow, but any window under it).

* views are only brought to front if their top line is clicked

I'm not sure either of these are actually part of his PR and they certainly are not severe enough to not approve an merge.

Well done @BDisp !
BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Aug 27, 2021
@BDisp
Fixes gui-cs#1446. Added more features to the Border and Toplevel focus.
eeb084b
@tig tig closed this as completed in d55ae77 Oct 5, 2021
BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Oct 5, 2021
@BDisp @En3Tho @dependabot
Fixes gui-cs#1446. Added more features to the Border and Toplevel foc…
22fe6be 
…us. (gui-cs#1447)

* Fixes gui-cs#1446. Added more features to the Border and Toplevel focus.

* Prevents throwing exception on negative effect3DOffset values

* Ensures that a view can be focused.

* Only sets focus if it isn't disposing.

* Fixes ViewToScreen and DrawChildBorder Effect3D.

* Unit test for negative coordinates with the ViewToScreen method.

* Added Tab navigation feature to the Editor scenario.

* ComboBox cursonDownKey nullref fix (gui-cs#1472)

* added null guard to fix null ref when pressing keyDown inside combobox
Improved an error message when view cannot be found

* Added a unit test to ensure combobox can process all key events
Found and fixed a new nullref

* Found a new bug when source is already present and combobox is added to a top view

* searchSet is auto initialized to new List() now to make the code a little bit safer

* Fixes WindowsDriver HeightAsBuffer set to false. (gui-cs#1466)

* Bump ReportGenerator from 4.8.12 to 4.8.13 (gui-cs#1473)

Bumps [ReportGenerator](https://github.com/danielpalme/ReportGenerator) from 4.8.12 to 4.8.13.
- [Release notes](https://github.com/danielpalme/ReportGenerator/releases)
- [Commits](danielpalme/ReportGenerator@v4.8.12...v4.8.13)

---
updated-dependencies:
- dependency-name: ReportGenerator
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixes gui-cs#1445. Fixing more the Curses and WSL clipboard. (gui-cs#1448)

* Fixes gui-cs#1445. Fixing more the Curses and WSL clipboard.

* Fixing unit tests.

* Changing namespace.

* Fixes WSL2 clipboard unit test.

* Upgrades devcontainer with the MainLoop fix.

* Fixes pasting with no selection and with lines break.

* Prevents the event button click being fired after a button pressed with mouse move.

* Fixes the char [ not being processed.

* Added Application.QuitKey property to allow change the quitting application key. (gui-cs#1450)

* Added Application.QuitKey property to allow change the quitting application key.

* Fixes QuitKey unit test by reseting his value.

* Locks timeouts until is added.

* Fixes gui-cs#1467. AlternateForward/BackwardKey bypasses dialog modality (gui-cs#1468)

* Changed namespace.

* Fixing merge conflicts.

* Fixes mouse click issue.

* Removing windows resizing because buffer resizing is enough.

* Fixes gui-cs#1477. Mouse click and console bottom on Windows Terminal.

Co-authored-by: Igor Bagdamyan <37334640+En3Tho@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@BDisp
Copy link
Collaborator Author

BDisp commented Oct 5, 2021

I'm not sure either of these are actually part of his PR and they certainly are not severe enough to not approve an merge.

This PR fixes both of your recommendations.

  • If you run the "Borders Comparisons" scenario and move the Window over the FrameView and the Toplevel over the Window, you will check that clicking on one of the shadow will activate the view under it. If you click on a shadow that is over another shadow, the current focused view will continue focused.

  • Views are now brought to front clicking on any place of the view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BDisp