Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment script should only optionally download monkey binaries using GH API #552

Open
danielguardicore opened this issue Feb 23, 2020 · 1 comment
Open

Deployment script should only optionally download monkey binaries using GH API #552

danielguardicore opened this issue Feb 23, 2020 · 1 comment
Assignees
@danielguardicore
Labels
Beginner friendly New to the project? This issue is good for you! Complexity: Low DevOps Documentation Issues relating to the project's documentation like readme files, guides, etc. Enhancement Issue that describes an enhancement to a current feature. Impact: Low

Comments

@danielguardicore
Copy link
Contributor

Currently Island development scripts download the latest release binaries in a hard coded manner.
This is non optimal for two reasons

  • If the developer is going to modify the Monkey they will likely compile their own version
  • We need to constantly update links.

Describe the solution you'd like
Download script should query the GH API for the latest binaries and download them, rather than use hard coded version numbers.
Also, this download should be gated behind an optional parameter, defaulting to yes.
@danielguardicore danielguardicore added Enhancement Issue that describes an enhancement to a current feature. Island Beginner friendly New to the project? This issue is good for you! Documentation Issues relating to the project's documentation like readme files, guides, etc. labels Feb 23, 2020
@danielguardicore danielguardicore self-assigned this Feb 23, 2020
@ashish493 ashish493 mentioned this issue Mar 12, 2020
Closed
@VakarisZ
Copy link
Contributor

Instead of optional cmd parameter to not download binaries it would be better to include dev scripts for building and replacing binaries, building island and other useful stuff.

@VakarisZ VakarisZ removed the Island label Feb 25, 2021
@snyk-bot snyk-bot mentioned this issue Jan 18, 2023
Open
@snyk-bot snyk-bot mentioned this issue Feb 11, 2023
Open
@SarmadBytes SarmadBytes mentioned this issue Nov 23, 2023
Open
@SarmadBytes SarmadBytes mentioned this issue Mar 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielguardicore danielguardicore

Labels
Beginner friendly New to the project? This issue is good for you! Complexity: Low DevOps Documentation Issues relating to the project's documentation like readme files, guides, etc. Enhancement Issue that describes an enhancement to a current feature. Impact: Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielguardicore @VakarisZ