PermissionError when running local monkey

[ilija-lazoroski]

Describe the bug

When we try to run the agent from the island using Run Local Monkey service on Windows sometimes we get PermissionError that we can't access the agent.

This is a bit racey due to the fact that the agent can still be running on the machine.
The issue is produced by this lines:

monkey/monkey/monkey_island/cc/services/run_local_monkey.py

Lines 61 to 68 in e587368

	try:
	with open(dest_path, "wb") as dest_agent:
	copyfileobj(agent_binary, dest_agent)
	dest_path.chmod(stat.S_IRWXU | stat.S_IRWXG)
	except Exception as exc:
	logger.error("Copy file failed", exc_info=True)
	return False, "Copy file failed: %s" % exc

What was tried is using common.utils.file_utils.open_securely_permissioned_file which doesn't create the agent if it is already existing.

To Reproduce

Steps to reproduce the behavior:

1. Run depth_3 BB tests couple of time
2. You should see error.

Expected behavior

Two things shouldn't happen: the agent should be stopped and not used by a process and the agent should be created on the machine regardless if it is existing or not.

Screenshots

Error message now.

The check with common.utils.file_utils.open_securely_permissioned_file

Machine version (please complete the following information):

• OS: Windows

[mssalvatore]

This is probably caused by #3543

[mssalvatore]

I think this is resolved by #3557 and #3543. @ilija-lazoroski Please confirm.

[cakekoa]

Confirmed, this is resolved by #3543