Modify shell startup files is not reported correctly

[ilija-lazoroski]

Describe the bug

If the modify shell startup files PBA fails it is not reported correctly.

To Reproduce

Steps to reproduce the behavior:

1. Configure to run the Modify shell startup files PBA
2. Run Monkey from source and make the PBA to fail
3. Check report to see that it shows .bash profile and .bashrc technique shows Not Attempted

Expected behavior

It should show that the technique is tried but failed

Screenshots

Machine version (please complete the following information):

• OS: Linux

[shreyamalviya]

Took a quick look and I believe this is the issue:

1. Since the attack fails, the result does not contain ".bash" or ".profile".
2. Mongo query returns nothing and info is an empty list.
3. status remains UNSCANNED since the block of code where it should change is never reached.

[ilija-lazoroski]

Nice found! We need to revise the whole PBA.

[shreyamalviya]

Thanks!
Not necessarily. This is, again, related to #1480. I'm trying to find a way to make this reliable.