Prevent polling just because the adapter gem was already required #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listen::Adapter.load_dependend_adapter returns true even if already loaded. Otherwise, if (for example) `gem "rb-fsevent"` already appears in a Gemfile or some other gem requires the adapter_gem before we do, Listen will always fall back to polling.
|
Nice thanks! |
thibaudgg
added a commit
that referenced
this pull request
May 28, 2013
Prevent polling just because the adapter gem was already required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen::Adapter.load_dependend_adapter returns true even if already loaded. Otherwise, if (for example)
gem "rb-fsevent"already appears in a Gemfile or some other gem requires the adapter_gem before we do, Listen will always fall back to polling.Any thoughts on this approach of fixing the problem?