Kill poller_thread before waiting for it to die #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stopping, each adapter needs to kill its poll thread before it can wait for it to exit - this ensures Guard can quit reliably without hanging.
|
Changes Unknown when pulling 042f4d0 on antifuchs:kill-poller-thread-before-joining into * on guard:master*. |
|
Awesome thanks, really nice digging. |
thibaudgg
added a commit
that referenced
this pull request
May 14, 2013
Kill poller_thread before waiting for it to die
|
Version 1.1.1 released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that recent guard versions sometimes fail to exit if there's a poller thread running: If so, it'll just hang on exit after saying "INFO - Bye bye...". When Ctrl-C'ing that, it will return you to the REPL and quitting immediately afterwards (via "quit") works.
I tracked this problem down to the listen adapter waiting for a poller thread to quit without actually telling it to terminate.
This patch kills the poller thread before joining the thread, which makes guard reliably exit. I hope you'll consider including this in a release (-: