:hide_success shows success notification after a failure #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! I'm on holiday until the first week of August and won't be able to merge this. I'll have a look asa after returning.... |
|
👋 Just a ping @netzpirat in case you forgot this PR! ;) |
|
Oh sh**, totally missed that. Thanks @rymai |
|
Aha, no problem, I was doing a bit of cleaning in the Guard org's pull-requests! :) |
netzpirat
added a commit
that referenced
this pull request
Sep 25, 2013
:hide_success shows success notification after a failure
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The :hide_success previously prevented all notification of success. This commit makes guard-coffeescript notify of a successful run after a failure or failures, even with :hide_success set to true. This conforms to a standard pattern of notification of success after failure (an "all clear" notification).
Before this change, when using the terminal_notifier, the terminal title would continue to show an error message even after the error had been fixed and there had been a successful compile.
(Also fixed some awkward grammar in one of the spec names.)