Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warnAboutGHooks() should exit with an error #49

Closed
julien-f opened this issue Mar 21, 2016 · 1 comment
Closed

warnAboutGHooks() should exit with an error #49

julien-f opened this issue Mar 21, 2016 · 1 comment

Comments

@julien-f
Copy link
Contributor

Because missing ghooks is similar to a hook failing.

Therefore: process.exit(1).
@kentcdodds
Copy link
Contributor

I think that's a good change. Feel free to makeapullrequest.com

ta2edchimp pushed a commit to ta2edchimp/ghooks that referenced this issue Mar 27, 2016
@julien-f @ta2edchimp
Exit with error if ghooks is not found (fix ghooks-org#49)
9a118f7
ta2edchimp pushed a commit to ta2edchimp/ghooks that referenced this issue Mar 30, 2016
@julien-f @ta2edchimp
Exit with error if ghooks is not found (fix ghooks-org#49)
da08b70
@ta2edchimp ta2edchimp mentioned this issue Mar 31, 2016
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julien-f @kentcdodds